[20291] Gather-send implementation #4537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cferreiragonz
force-pushed
the
poc/gather-send-implementation
branch
2 times, most recently
from
aa6e6cc
to
5de9ef4
Compare
cferreiragonz
force-pushed
the
poc/gather-send-implementation
branch
from
02e2919
to
af3951c
Compare
7 tasks
cferreiragonz
force-pushed
the
poc/gather-send-implementation
branch
2 times, most recently
from
376e650
to
261c9a0
Compare
cferreiragonz
force-pushed
the
poc/gather-send-implementation
branch
from
261c9a0
to
3067287
Compare
cferreiragonz
force-pushed
the
poc/gather-send-implementation
branch
3 times, most recently
from
86c7d43
to
c3741e5
Compare
JLBuenoLopez
force-pushed
the
3.0.x-devel
branch
from
2de726b
to
4a61143
Compare
cferreiragonz
force-pushed
the
poc/gather-send-implementation
branch
from
c3741e5
to
6752776
Compare
cferreiragonz
force-pushed
the
poc/gather-send-implementation
branch
from
6752776
to
9344ae3
Compare
cferreiragonz
force-pushed
the
poc/gather-send-implementation
branch
from
9344ae3
to
3ff583d
Compare
EduPonz
force-pushed
the
3.0.x-devel
branch
2 times, most recently
from
8193fef
to
a364ed8
Compare
github-actions
bot
force-pushed
the
3.0.x-devel
branch
from
18d8c6e
to
f3b3af6
Compare
JesusPoderoso
force-pushed
the
3.0.x-devel
branch
from
943b988
to
2c47b5e
Compare
github-actions
bot
force-pushed
the
3.0.x-devel
branch
from
2c47b5e
to
c978d52
Compare
EduPonz
force-pushed
the
3.0.x-devel
branch
3 times, most recently
from
5148f5d
to
bd83bb2
Compare
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
cferreiragonz
force-pushed
the
poc/gather-send-implementation
branch
from
394adb8
to
8a9eede
Compare
MiguelCompany
requested changes
Jun 13, 2024
|
@richiprosima Please test_3 discovery-server |
Signed-off-by: cferreiragonz <[email protected]>
MiguelCompany
approved these changes
Jun 13, 2024
JesusPoderoso
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Refs #20337: Buffer list in UDP sending function Signed-off-by: cferreiragonz <[email protected]> * Refs #20337: Buffer list in SHM sending function & Copy to shared buffer function Signed-off-by: cferreiragonz <[email protected]> * Refs #20337: Buffer list in TCP sending function Signed-off-by: cferreiragonz <[email protected]> * Refs #20342: Add new Buffer structure Signed-off-by: cferreiragonz <[email protected]> * Refs #20342: Add new lambda to send buffers into SenderResources Signed-off-by: cferreiragonz <[email protected]> * Refs #20342: Refactor on UDP transport Signed-off-by: cferreiragonz <[email protected]> * Refs #20342: Refactor on UDP test_transport Signed-off-by: cferreiragonz <[email protected]> * Refs #20342: Refactor on TCP Transport Signed-off-by: cferreiragonz <[email protected]> * Refs #20342: Refactor on TCPChannelResource Signed-off-by: cferreiragonz <[email protected]> * Refs #20342: Refactor on TCP tests Signed-off-by: cferreiragonz <[email protected]> * Refs #20342: Refactor on SHM transport & enable copying multiple buffers Signed-off-by: cferreiragonz <[email protected]> * Refs #20342: Refactor on SHM tests Signed-off-by: cferreiragonz <[email protected]> * Refs #20342: Fix mock tests after rebase Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Refactor on addSubmessageData/DataFrag Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Add constructor overloads to NetworkBuffers Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Add new attributes and methods to RTPSMessageGroup.h Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Refactor on add_data() Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Refactor on add_data_frag() Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Refactor on insert_submessage() Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Refactor on send() Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Minor changes in RTPSMessageGroup Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Refactor on RTPSMessageSenderInterface Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Refactor on ChaningTransport and ABI compatible send_lambda_ Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Refactor on Statistics module Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Add security support Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Minor fixes Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Doxygen Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Delete Sender's Resource deprecated API Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Fix Windows build Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Account for change of namespaces Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Add NetworkBuffer.cpp Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Revision minor changes Signed-off-by: cferreiragonz <[email protected]> * Refs #20352: Revision minor changes 2 Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Avoid stats_msg dynamic malloc Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Use vector instead of list Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Refactor RTPSMessageGroup to avoid Mallocs Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Use limited vector to avoid repeated mallocs Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Fix rebase Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Improve doxygen Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Revision Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Add ResourceLV config into QoS Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: XML - New QoS added Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Get Payload in RTPSMessageGroup Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Revision - Use RLContainerConfig and minor changes Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Revision - Get payload after correct RTPSMsg creation Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Revision - Default values Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Update versions.md & CMakeLists Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Revision - Headers & versions.md Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Adjust payload_pool test Signed-off-by: cferreiragonz <[email protected]> * Refs #20291: Test comment Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the creation and sending of RTPS Messages by utilizing a list of
NetworkBuffers(pointers + sizes) as the data transmission object, thereby eliminating an additional data message copy in theRTPSMessageGroup.This refactor impacts both the Transports and the RTPS Layer, involving updates to the sender resources lambda functions, transport interfaces, statistics module, and the logic implemented in RTPS message creation.
Two extra
ResourceLimitedVectorshave been added toRTPSMessageGroup_tto act asNetworkBuffersand to contain the metadata of the payloads used in the creation of the RTPS message. In this way mallocs can be reduced as much as possible during runtime. TCP transport has mallocs during the creation of the TCP message and during the asio write operation.SendBuffersAllocationAttributeshas been extended with a new attribute defining the allocation configuration of theNetworkBuffers.payload_owner_Opened as draft:
Contributor Checklist
versions.mdfile (if applicable).Related documentation PR: [20291] Gather-send implementation Docs Fast-DDS-docs#724
Reviewer Checklist