Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21094] Example refactor: Custom payload pool #4889

Merged
merged 14 commits into from
Jun 13, 2024
Merged

[21094] Example refactor: Custom payload pool #4889

merged 14 commits into from
Jun 13, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jun 3, 2024 •
edited by JesusPoderoso
Loading

Description

This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.
The custom_payload_pool_example is a refactor of CustomPayloadPoolExample.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Jun 3, 2024
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Jun 3, 2024
@MiguelCompany
Copy link
Member

@elianalf This should be rebased on top of #4892

JesusPoderoso

This comment was marked as resolved.

Sign in to view

@JesusPoderoso JesusPoderoso added to-do needs rebase and removed needs-review PR that is ready to be reviewed labels Jun 6, 2024
@elianalf elianalf force-pushed the feature/example_refactor/custom_payload_pool branch from 4574a96 to 8245d1e Compare June 6, 2024 10:54
JesusPoderoso

This comment was marked as resolved.

Sign in to view

@JesusPoderoso JesusPoderoso self-requested a review June 7, 2024 08:09
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 7, 2024
JesusPoderoso
JesusPoderoso previously approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@JesusPoderoso JesusPoderoso added temporarily-blocked PR must be merged after another one and removed to-do labels Jun 7, 2024
@JesusPoderoso JesusPoderoso mentioned this pull request Jun 10, 2024
Closed
15 tasks
@elianalf elianalf force-pushed the feature/example_refactor/custom_payload_pool branch from ade4570 to d8ec03c Compare June 11, 2024 13:30
JesusPoderoso
JesusPoderoso previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@elianalf elianalf force-pushed the feature/example_refactor/custom_payload_pool branch from d8ec03c to 9a10330 Compare June 12, 2024 06:40
@elianalf elianalf force-pushed the feature/example_refactor/custom_payload_pool branch from 9a10330 to 47bee8b Compare June 12, 2024 14:41
@elianalf elianalf requested review from JesusPoderoso and removed request for JesusPoderoso June 12, 2024 14:43
@elianalf elianalf removed the temporarily-blocked PR must be merged after another one label Jun 13, 2024
@elianalf
Copy link
Contributor Author

Windows CI passed here

JesusPoderoso
JesusPoderoso approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job 🏅

(CI passed in previous commit)

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 13, 2024
@EduPonz EduPonz merged commit e0fdeb9 into master Jun 13, 2024
3 of 4 checks passed
@EduPonz EduPonz deleted the feature/example_refactor/custom_payload_pool branch June 13, 2024 10:53
JesusPoderoso pushed a commit that referenced this pull request Jun 13, 2024
@elianalf @JesusPoderoso
Example refactor: Custom payload pool (#4889)
ea82731 
* Refs #21094: Change folder name and delete old folder

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Refactor of the main

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Add CLI Parser

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Publisher refactor

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Subscriber refactor

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Change example name and fix interval parsing

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Add test

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Update version.md

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Apply suggestions: Use HelloWOrld instead of CUstomPayloadPoolData

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Apply suggestions

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Update ReadMe file

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Uncrustify

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Split test

Signed-off-by: elianalf <[email protected]>

* Refs #21094: Fix compilation error in Windows

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@elianalf @MiguelCompany @JesusPoderoso @EduPonz