Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21314] Improve resilience against clock adjustments (backport #5018) #5189

Open
wants to merge 4 commits into
base: 2.14.x
Choose a base branch
from
Open

[21314] Improve resilience against clock adjustments (backport #5018) #5189

wants to merge 4 commits into from

Commits on Nov 15, 2024

  1. Improve resilience against clock adjustments (#5018) 

    * Use steady_clock instead of high_resolution_clock for status checks (high_resolution_clock might not be steady depending on STL impl)

Signed-off-by: Matthias Schneider <[email protected]>

* Use steady_clock instead for system_clock for calculating timeouts

Signed-off-by: Matthias Schneider <[email protected]>

* Use correct clock's duration for duration_cast

Signed-off-by: Matthias Schneider <[email protected]>

* Use Time_t::now()

Signed-off-by: Matthias Schneider <[email protected]>

* Fix build.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21314. Refactor on DataWriterImpl.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21314. Refactor on DataReaderImpl.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21314. Refactor on StatefulWriter.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21314. Protect current_time_since_unix_epoch against clock adjustments.

Signed-off-by: Miguel Company <[email protected]>

* Revert "Use steady_clock instead of high_resolution_clock for status checks (high_resolution_clock might not be steady depending on STL impl)"

This reverts commit d69eb91.

---------

Signed-off-by: Matthias Schneider <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit ccc690c)
    @ma30002000 @MiguelCompany
    ma30002000 authored and MiguelCompany committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9aa78cd View commit details
    Browse the repository at this point in the history

  2. Refs #21314: Fix conflicts and build issues 

    Signed-off-by: JesusPoderoso <[email protected]>
    @JesusPoderoso @MiguelCompany
    JesusPoderoso authored and MiguelCompany committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8a0d552 View commit details
    Browse the repository at this point in the history

  3. Refs #21314: Apply rev suggestions 

    Signed-off-by: JesusPoderoso <[email protected]>
    @JesusPoderoso @MiguelCompany
    JesusPoderoso authored and MiguelCompany committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ffc4271 View commit details
    Browse the repository at this point in the history

  4. Refs #21314: Please uncrustify 

    Signed-off-by: JesusPoderoso <[email protected]>
    @JesusPoderoso @MiguelCompany
    JesusPoderoso authored and MiguelCompany committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    b235fd6 View commit details
    Browse the repository at this point in the history