-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21982] Tests for regression test: fix sequence of alias of primitives inside modules #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiware
changed the title
Tests for regression test: fix sequence of alias of primitives inside modules
[21982] Tests for regression test: fix sequence of alias of primitives inside modules
Oct 24, 2024
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware
force-pushed
the
bugfix/21978
branch
from
October 25, 2024 09:16
b1fa127
to
d46938c
Compare
Mario-DL
requested changes
Oct 28, 2024
test/feature/dynamic_types/dds_types_tests/DynamicTypesSequencesDDSTypesTests.cpp
Outdated
Show resolved
Hide resolved
test/feature/dynamic_types/dds_types_tests/DynamicTypesSequencesDDSTypesTests.cpp
Outdated
Show resolved
Hide resolved
test/feature/dynamic_types/dds_types_tests/DynamicTypesSequencesDDSTypesTests.cpp
Outdated
Show resolved
Hide resolved
test/feature/dynamic_types/dds_types_tests/DynamicTypesSequencesDDSTypesTests.cpp
Outdated
Show resolved
Hide resolved
7 tasks
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Mario-DL
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with Green CI
Mario-DL
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for the new type in
dds-types-test
repository which was included as regression test forfastddsgen
.Depends on:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist