Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ament packaging #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

artivis
Copy link

@artivis artivis commented Jan 18, 2023

Several packages provided by eProsima offer the possibility to be built with colcon. However said packages do not install their package.xml file nor do they populate the ament index.
This PR add two macros to cmake_utils to do just that. Plus they are invoked from the eprosima_packaging macro when a build with ament is detected.

Note that of course packages that aren't using this macro will not benefit from this quick fix, e.g. fastdds.

Related to ros-infrastructure/rosdep#724

@artivis artivis temporarily deployed to codecov January 19, 2023 07:21 — with GitHub Actions Inactive
@artivis artivis temporarily deployed to codecov January 19, 2023 07:28 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Base: 71.18% // Head: 71.51% // Increases project coverage by +0.32% 🎉

Coverage data is based on head (08a9144) compared to base (932abda).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   71.18%   71.51%   +0.32%     
==========================================
  Files          49       50       +1     
  Lines         819      853      +34     
  Branches      187      202      +15     
==========================================
+ Hits          583      610      +27     
  Misses        134      134              
- Partials      102      109       +7     
Impacted Files Coverage Δ
cpp_utils/src/cpp/exception/Exception.cpp 72.72% <0.00%> (ø)
cpp_utils/src/cpp/file/file_utils.cpp 61.11% <0.00%> (ø)
cpp_utils/src/cpp/utils.cpp 78.12% <0.00%> (+15.62%) ⬆️
...p_utils/include/cpp_utils/types/impl/Singleton.ipp 100.00% <0.00%> (+20.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants