fix(connection): readOptionsFromEnv sets protocol

This is needed to allow REST connections using `http:` to override the default (`https:`).
eXist-db · Oct 18, 2023 · a7076a9 · a7076a9
1 parent 766641a
commit a7076a9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/components/connection.js b/components/connection.js
@@ -147,6 +147,7 @@ function readOptionsFromEnv () {
     environmentOptions.secure = protocol === 'https:'
     environmentOptions.host = hostname
     environmentOptions.port = port
+    environmentOptions.protocol = protocol
   }
 
   return environmentOptions

diff --git a/spec/tests/readenv.js b/spec/tests/readenv.js
@@ -12,10 +12,12 @@ test('connection options from environment', function (t) {
     t.equal(optionsFromEnv.port, port)
     t.equal(optionsFromEnv.secure, protocol === 'https:')
     t.equal(optionsFromEnv.host, hostname)
+    t.equal(optionsFromEnv.protocol, protocol)
   } else {
     t.false('port' in optionsFromEnv)
     t.false('secure' in optionsFromEnv)
     t.false('host' in optionsFromEnv)
+    t.false('protocol' in optionsFromEnv)
   }
 
   if (userIsSet) {