fix(#7): deprecated ip

deprecated ip Signed-off-by: ysicing <[email protected]>
easysoft · Jul 20, 2023 · 58ac393 · 58ac393
1 parent 78b51c9
commit 58ac393
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/cmd/flags/common.go b/cmd/flags/common.go
@@ -71,6 +71,9 @@ func ConvertFlags(cmd *cobra.Command, fs []types.Flag) *pflag.FlagSet {
 				if f.Required {
 					_ = cobra.MarkFlagRequired(pf, f.Name)
 				}
+				if f.Hidden {
+					pf.MarkHidden(f.Name)
+				}
 			}
 		} else {
 			if cmd.Flags().Lookup(f.Name) == nil {
@@ -92,6 +95,9 @@ func ConvertFlags(cmd *cobra.Command, fs []types.Flag) *pflag.FlagSet {
 				if f.Required {
 					_ = cobra.MarkFlagRequired(pf, f.Name)
 				}
+				if f.Hidden {
+					pf.MarkHidden(f.Name)
+				}
 			}
 		}
 

diff --git a/internal/pkg/types/cluster.go b/internal/pkg/types/cluster.go
@@ -63,6 +63,7 @@ type Flag struct {
 	ShortHand string
 	Usage     string
 	Required  bool
+	Hidden    bool
 	EnvVar    string
 }
 

diff --git a/pkg/quickon/quickon.go b/pkg/quickon/quickon.go
@@ -66,10 +66,11 @@ func (m *Meta) GetFlags() []types.Flag {
 			V:     m.Domain,
 		},
 		{
-			Name:  "ip",
-			Usage: "quickon ip",
-			P:     &m.IP,
-			V:     m.IP,
+			Name:   "ip",
+			Usage:  "quickon ip",
+			P:      &m.IP,
+			V:      m.IP,
+			Hidden: true,
 		},
 		{
 			Name:  "version",