Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update buffer too fast #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mix5003
Copy link
Contributor

@mix5003 mix5003 commented Dec 28, 2017

when browser updating we can not appendBuffer so we should wait before until updateend before add new chunk.

or may be use queue for speed up like this link?

@ebidel
Copy link
Owner

ebidel commented Dec 30, 2017

Haven't touched this api in a while :)

The demo still works for me: https://html5-demos.appspot.com/static/media-source.html. Is this the cause of the console error?

@mix5003
Copy link
Contributor Author

mix5003 commented Dec 30, 2017

in firefox it error in console is InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable

@mix5003
Copy link
Contributor Author

mix5003 commented Jan 5, 2018

i just found this patch will fix Failed to execute 'endOfStream' on 'MediaSource': The 'updating' attribute is true on one or more of this MediaSource's SourceBuffers. in
Chrome Version 63.0.3239.108 (Official Build) (64-bit) on Linux Mint 18.3 too

i think it because endOfStream() was call before updateend (it still updating).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants