Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enchance refractor clean up #21

Open
wants to merge 42 commits into
base: prod
Choose a base branch
from
Open

Enchance refractor clean up #21

wants to merge 42 commits into from

Commits on Jun 27, 2021

  1. removed redundant codes and rubbish comments

    @ebiggerr
    ebiggerr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    099f5f7 View commit details
    Browse the repository at this point in the history

  2. optimized imports by removing unnecessary imports of libraries.

    @ebiggerr
    ebiggerr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    f5ab1e9 View commit details
    Browse the repository at this point in the history

  3. changed the signature of the exception and refine the log message.

    @ebiggerr
    ebiggerr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    4c1636c View commit details
    Browse the repository at this point in the history

  4. updated the license signature in every java files

    @ebiggerr
    ebiggerr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    d0fdf1e View commit details
    Browse the repository at this point in the history

  5. removed deprecated code

    @ebiggerr
    ebiggerr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    56c0300 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. add logger into the class 

    changed the return of the method generateTokenAuthentication() when there is something wrong during the creation of JWT
    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    6cc24e2 View commit details
    Browse the repository at this point in the history

  2. handling the creation of JWT if the username is null

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    dec0f0c View commit details
    Browse the repository at this point in the history

  3. changed "return" to inline 

    - cleaner code
    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    545bf6b View commit details
    Browse the repository at this point in the history

  4. removed unnecessary comments

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    c3fad43 View commit details
    Browse the repository at this point in the history

  5. removed unnecessary comments

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    2ad9ef1 View commit details
    Browse the repository at this point in the history

  6. repetitive usage of 1, thus changed it to CONSTANT : DEFAULT_FIRST_PAGE 

    with the value of 1
    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    18fdcf2 View commit details
    Browse the repository at this point in the history

  7. removed the dependency on historicalSalesService ( unused, deprecated )

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    f2bc64f View commit details
    Browse the repository at this point in the history

  8. add the method of update an existing item in the inventory

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    ec0daae View commit details
    Browse the repository at this point in the history

  9. updated the documentation of methods in the inventoryService.java

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    cfc4b9e View commit details
    Browse the repository at this point in the history

  10. added the field of "id"

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    c663cf9 View commit details
    Browse the repository at this point in the history

  11. added an endpoint that allows user to update an existing item in the … 

    …inventory
    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    ed4ca6b View commit details
    Browse the repository at this point in the history

  12. updated the antMatchers in WebSecurity_Config.java

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    6155052 View commit details
    Browse the repository at this point in the history

  13. optimized imports

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    65ba59e View commit details
    Browse the repository at this point in the history

  14. update the README.md with screenshots of Postman

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    6dbddbf View commit details
    Browse the repository at this point in the history

  15. update the README.md

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    2e72a68 View commit details
    Browse the repository at this point in the history

  16. update the README.md

    @ebiggerr
    ebiggerr committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    350bcfe View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Renamed all the classes and interfaces in Pascal Case style.

    @ebiggerr
    ebiggerr committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    bc738ae View commit details
    Browse the repository at this point in the history

  2. renamed the method generateTokenAuthentication to generateToken

    @ebiggerr
    ebiggerr committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    498d8c8 View commit details
    Browse the repository at this point in the history

  3. add comments

    @ebiggerr
    ebiggerr committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    d415eb8 View commit details
    Browse the repository at this point in the history

  4. renamed the name of the methods in AccountMainController.java

    @ebiggerr
    ebiggerr committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    e1eaf20 View commit details
    Browse the repository at this point in the history

  5. -renamed the methods name in RestockController.java 

    -renamed AddStockForAnItem to addStockForAnItem in RestockController.java (updated StockService.java as there is a usage of this method)
-removed unused comments in RestockController.java
    @ebiggerr
    ebiggerr committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    867eba2 View commit details
    Browse the repository at this point in the history

  6. update template for application.properties

    @ebiggerr
    ebiggerr committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    3fa3551 View commit details
    Browse the repository at this point in the history

  7. renamed the name of methods for better description 

    -enumeration for PostgreSQL
-updated the method of account registration in AccountService.java
-added "accountemail" to AccountEntity.java
    @ebiggerr
    ebiggerr committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    e80b905 View commit details
    Browse the repository at this point in the history

  8. PostgreSQL enum type

    @ebiggerr
    ebiggerr committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    6bdcb73 View commit details
    Browse the repository at this point in the history

  9. changed the name of method

    @ebiggerr
    ebiggerr committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    7b9f262 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'prod' into enchance-refractor-clean-up

    @ebiggerr
    ebiggerr authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    f99c785 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2021

  1. Fix : Comment out the @transactional will cause the update query to f… 

    …ail.
    @ebiggerr
    ebiggerr committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    768c47b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'prod' into enchance-refractor-clean-up

    @ebiggerr
    ebiggerr committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    70f93a1 View commit details
    Browse the repository at this point in the history

  3. Fix - removed test

    @ebiggerr
    ebiggerr committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    3fbf474 View commit details
    Browse the repository at this point in the history

  4. Fix - comment out to prevent compile error/ expect to deprecate or re… 

    …write the test
    @ebiggerr
    ebiggerr committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    a58fae7 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Feature - Update database schema to support batch expiry tracking in … 

    …the future upcoming version
    @ebiggerr
    ebiggerr committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    09ef535 View commit details
    Browse the repository at this point in the history

  2. Feature : Improve the restock update by adding information on who per… 

    …forming the restock operation by saving the accountId along with the record.
    @ebiggerr
    ebiggerr committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d8bab6f View commit details
    Browse the repository at this point in the history

  3. Feature - update database schema for expiry tracking

    @ebiggerr
    ebiggerr committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    e32b15e View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2021

  1. Changes made to things related to the account controller 

    1. More comment
    @ebiggerr
    ebiggerr committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    8508b22 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Enhance - Lazy to do meaningful commit

    @ebiggerr
    ebiggerr committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    fb4d4f1 View commit details
    Browse the repository at this point in the history

  2. Enhance - Lazy

    @ebiggerr
    ebiggerr committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    5979e00 View commit details
    Browse the repository at this point in the history

  3. Enhance - Throwing and catching exception

    @ebiggerr
    ebiggerr committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    6f67568 View commit details
    Browse the repository at this point in the history