Add Assets install rule to Distance #1463
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the most widely-used mods for Distance is the Custom Car mod, adding the ability to use custom car models which are all made by different authors and historically managed in this repo.
With Distance being added to Thunderstore, we'd like individual car model authors to be able to publish their cars there as separate packages users can install individually, but each car isn't a mod itself, just a Unity asset file, and previously, pre-Thunderstore, they would all be placed within an Assets folder inside the core mod's plugin folder (
..\BepInEx\plugins\CustomCar\Assets\<any structure>\CarFile
with..\BepInEx\plugins\CustomCar\CustomCar.dll
). However, that structure, putting assets inside the folder of a different plugin, doesn't seem to be possible with r2's install rules. So this PR change would allow us to use a top-level Assets folder (..\BepInEx\Assets\
) similar to GTFO (as per the "Structuring your Thunderstore package" wiki page), and we can update our core custom car mod to read from both locations.If there is a way to structure the individual car asset packages such that they would get installed to
..\BepInEx\plugins\<team>-CustomCar\Assets\<car author>\CarFile
or similar without this PR and us having to update our existing core mod, please let me know.There is also already a PR open to add a Cars section to Thunderstore where these custom car assets will be listed: thunderstore-io/ecosystem-schema#74
And if this change also needs to be made separately somewhere for the Thunderstore App, I couldn't find where to do that.