Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling read profile file #1528

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

VilppeRiskidev
Copy link
Collaborator

No description provided.

@VilppeRiskidev
Copy link
Collaborator Author

Oops, I didn't amend the commits, so there're 2 commits for no reason 😆

src/utils/ProfileUtils.ts Outdated Show resolved Hide resolved
src/utils/ProfileUtils.ts Outdated Show resolved Hide resolved
src/utils/ProfileUtils.ts Outdated Show resolved Hide resolved
src/utils/ProfileUtils.ts Outdated Show resolved Hide resolved
src/utils/ProfileUtils.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good. Couple more small things on the call site side. Let me know if you think they aren't needed, in which case I can approve this.

src/components/profiles-modals/ImportProfileModal.vue Outdated Show resolved Hide resolved
src/components/profiles-modals/ImportProfileModal.vue Outdated Show resolved Hide resolved
@VilppeRiskidev
Copy link
Collaborator Author

VilppeRiskidev commented Nov 12, 2024

https://github.com/thunderstore-io/thunderstore-mod-manager/pull/281 is required for this to work correctly.

Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍🏻

@anttimaki anttimaki merged commit f9b018a into develop Nov 13, 2024
5 checks passed
@anttimaki anttimaki deleted the error-handling-read-profile-file branch November 13, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants