Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MelonLoader Improvements #1539

Merged
merged 2 commits into from
Nov 11, 2024
Merged

MelonLoader Improvements #1539

merged 2 commits into from
Nov 11, 2024

Conversation

ebkr
Copy link
Owner

@ebkr ebkr commented Nov 9, 2024

This PR fixes how we handle MelonLoader to prevent always passing --agfregenerate on MelonLoader 0.6.x.
Additionally we remove the "recommended" version for BONELAB as that should always be using the latest 0.6.x.

This functionality is pending a release of MelonLoader 0.6.6 (the next version) to work correctly. Once this has been released, we should expect to see correct behaviour with MelonLoader and BONELAB.

@ebkr ebkr requested a review from anttimaki November 9, 2024 22:18
Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully sure what's this is about but what I see makes sense to me. I assume it's intentional for BONEWORKS to keep using 0.5.4 as the recommended version?

@ebkr
Copy link
Owner Author

ebkr commented Nov 11, 2024

Yeah it's intentional. BONEWORKS doesn't work with the newer versions of ML.

The reason for the change is that the manager keeps passing --agfregenerate for BONELAB which causes an extremely slow startup time every time Start modded is clicked. This reduces that and makes it a much nicer experience by only regenerating when the file doesn't exist.

@ebkr ebkr merged commit 78a0402 into develop Nov 11, 2024
5 checks passed
@ebkr ebkr deleted the melonloader-improvements branch November 11, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants