Reduce time spent on the splash screen #1552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may want to get to the manager screen quickly so they can just launch the game with existing mods. Having to wait for the latest mod list update can be frustrating. Splash screen now only checks the API for a fresh list if no local cache is found at all. Handling different error scenarios is also omitted, and user is moved to profile selection screen even if no mod list can be loaded. Error screen offering a chance to retry loading the mod list is dropped. The idea is that the background update or a manually triggered mod list update will handle the mod list eventually. Note that the changes only affect the splash screen. Background updates still work the same way they did before. In the future the splash screen can be hastened even further e.g. by handling the loading of the exclusion list in the background and reducing the timeouts/retry attempts of the API calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may want to get to the manager screen quickly so they can just launch the game with existing mods. Having to wait for the latest mod list update can be frustrating.
Splash screen now only checks the API for a fresh list if no local cache is found at all. Handling different error scenarios is also omitted, and user is moved to profile selection screen even if no mod list can be loaded. Error screen offering a chance to retry loading the mod list is dropped. The idea is that the background update or a manually triggered mod list update will handle the mod list eventually.
Note that the changes only affect the splash screen. Background updates still work the same way they did before.
In the future the splash screen can be hastened even further e.g. by handling the loading of the exclusion list in the background and reducing the timeouts/retry attempts of the API calls.