This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Add replacements for hostName and hostPort #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could be useful in combination with reverse proxy to replace the host dynamically but let the port be static
blaubaer
suggested changes
May 31, 2019
| @@ -87,6 +88,12 @@ func (instance *ruleReplaceAction) contextRequestValueBy(name string) (string, b | |||
| return request.Method, true | |||
| case "host": | |||
| return request.Host, true | |||
| case "hostonly": | |||
There was a problem hiding this comment.
Hi. Maybe you can change it to hostName and add another line for hostPort, too. That it might be aligned.
There was a problem hiding this comment.
How to get the default port in error case? Is it enough to test the scheme and return 80 or 443?
|
PS: Please do not forget to adjust the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement variable
hostonlycould be useful in combination with reverse proxy to replace the host dynamically but let the port be static