Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get-assets): handle sub dir paths correctly #621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlexanderBabel
Copy link

I ran into an issue with subdirectories for the sentry source map upload. When a nested directory structure is used, the correct path is not generated by the getFiles function.

Example:
When using the following config:

{
  "urlPrefix":"/src",
  "sourcemaps": "dist"
}

A file with the path /Users/user/project/dist/modules/modules1/code-file.js is mapped to /src/modules1/code-file.js.

But the expected result would be: /src/modules/modules1/code-file.js.

Therefore, I crated this PR, which fixes the path generation for this use case.

@commit-lint
Copy link

commit-lint bot commented Jan 5, 2022

Bug Fixes

  • get-assets: handle sub dir paths correctly (db2bb84)

Contributors

AlexanderBabel

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants