fix modify after free crash

mThreadHandle must not be reset before the run method has finished
eclipse-4diac · Jul 24, 2024 · 59cd522 · 59cd522
1 parent 23d49a0
commit 59cd522
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/arch/threadbase.tpp b/src/arch/threadbase.tpp
@@ -46,7 +46,6 @@ template <typename TThreadHandle, TThreadHandle nullHandle, typename ThreadDelet
 void CThreadBase<TThreadHandle, nullHandle, ThreadDeletePolicy>::stop() {
   if(nullHandle != mThreadHandle){
     setAlive(false);
-    mThreadHandle = nullHandle;  //indicate that thread is in shutdownmode
   }
 }
 
@@ -75,6 +74,7 @@ void CThreadBase<TThreadHandle, nullHandle, ThreadDeletePolicy>::runThread(CThre
     paThread->setAlive(true);
     paThread->run();
     paThread->setAlive(false);
+    paThread->mThreadHandle = nullHandle;
     paThread->mJoinSem.inc();
     ThreadDeletePolicy::deleteThread(threadHandle);
   } else {