-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build equinox.compendium.tests and equinox.region.tests #22
Conversation
eb87e47
to
1651d40
Compare
The build currently fails with the following error:
Does anybody has an idea why? |
Bump the bundle BREE to JavaSE-11. IIRC there is issue with using Java 5 inside docker container. |
ef963ad
to
dd4c8b7
Compare
Thanks that was helpful already. I also added the missing extra-bundles to the Test-Runtime and autostarted Felix-SCR, but there are some more failures that the bundles created on the fly are not found. Maybe some paths have to be adjusted. |
When I run (or debug) this build locally on my computer everything works fine and the test-bundles are found. |
@HannesWell are you running same command as in the CI build? Particularly the
and tells (more or less explicitly) that it's not possible to do API check because the bundle is not present in baseline. So some pom.xml configuration must be added to set |
Thanks Mickael for the hint. Indeed I didn't activate the |
Disable currently failing RegionTests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recently moved the repository content to https://github.com/eclipse-equinox/equinox would you be so kind to open your PR for the new repository?
Migrated to eclipse-equinox/equinox#29 |
The tests in o.e.equinox.compendium.tests and o.e.equinox.region.tests are not obsolete and therefore should be build.
The tests in o.e.equinox.region.tests were disabled as part of Bug 470000 that had the goal to reduce/remove the dependencies to aspectj.
@tjwatson explained in #19 (comment) that the tests could function even without aspectj in the platform by using corresponding mocks.
For now I suggest to simply disable failing tests and to fix them later.
The reason is I would like the build to function with all projects in the repository. This way we can later fully leverage Tycho-pomless and don't have to list each module to build.