Extract retrieval of ShadowList into a method and invert conditions #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
invert_and_extract
branch
from
f207cf5
to
97d5931
Compare
tjwatson
reviewed
Mar 4, 2024
bundles/org.eclipse.osgi/felix/src/org/apache/felix/resolver/Candidates.java
Outdated
Show resolved
Hide resolved
laeubi
force-pushed
the
invert_and_extract
branch
2 times, most recently
from
afc3f0e
to
41bb006
Compare
laeubi
force-pushed
the
invert_and_extract
branch
from
41bb006
to
a023b8c
Compare
|
@tjwatson any further concerns or can we merge this? |
Currently the code to work with the ShadowList is quite hard to understand as it references in a quite big block and uses a negated condition with if/else. This extracts the retrieval of the ShadowList into a method to prevent accidentally using a wrong reference and inverts the condition so there is no negation involved.
laeubi
force-pushed
the
invert_and_extract
branch
from
a023b8c
to
0d857bc
Compare
tjwatson
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code to work with the ShadowList is quite hard to understand as it references in a quite big block and uses a negated condition with if/else.
This extracts the retrieval of the ShadowList into a method to prevent accidentally using a wrong reference and inverts the condition so there is no negation involved.
This makes is slightly easier to understand whats going on.