Do not copy the list returned by findCandidates #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least this seem not to break anything ... |
The specification requires that we pass in the original list of candidates to the insertHostedCapability but currently always a copy is performed. This replaces the copy by directly keeping the reference given as the resolver is woning the list anyways.
laeubi
force-pushed
the
do_not_copy_original
branch
from
0935276
to
b9f603a
Compare
|
@tjwatson what do you think? |
tjwatson
reviewed
Apr 22, 2024
| @@ -48,8 +48,8 @@ private ShadowList(CandidateSelector shadow, List<Capability> original) | |||
| } | |||
|
|
|||
| private ShadowList(List<Capability> unmodifiable, List<Capability> original, AtomicBoolean isUnmodifiable) { | |||
| super(unmodifiable, isUnmodifiable); | |||
| m_original = new ArrayList<Capability>(original); | |||
| super(new ArrayList<Capability>(unmodifiable), isUnmodifiable); | |||
There was a problem hiding this comment.
I don't understand the switch here to copy for the super call and not for the m_original
There was a problem hiding this comment.
This code a a bit cumbersome because it switches "unmodifiable" what actually is modified later on but the original is later passed to the ProvisonContext.
|
I'll close this for now as the specification will be changed in this aspect: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification requires that we pass in the original list of candidates to the insertHostedCapability but currently always a copy is performed.
This replaces the copy by directly keeping the reference given as the resolver is woning the list anyways.
See