Improve RepositoryHelper.getSharedBundlePools() to avoid exceptions #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully this is the last round! 😱 |
|
FYI, I've already committed these changes to Oomph and they are in a nightly build: So soon the encoding.info file will exist everywhere... |
HannesWell
approved these changes
Nov 5, 2023
...x.p2.repository/src/org/eclipse/equinox/internal/p2/repository/helpers/RepositoryHelper.java
Outdated
Show resolved
Hide resolved
Just log an exception and return an empty list in the unlikely event of failure. eclipse-equinox#373
laeubi
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just log an exception and return an empty list in the unlikely event of failure.
#373