Improve RepositoryHelper.getSharedBundlePools to load all agent pools

[merks]

Oomph has moved the encoding.info to be in the same folder as the agents.info which lists all the agent locations (rather than in the folder of the default agent's location). The agents.info file can be loaded to determine the location of the pools.info of each agent. This refined approach covers the full generality of Oomph's shared agent manager allows all pools of all agents to be located with no assumptions about defaults.

#373

[github-actions]

Test Results

       9 files  ±0         9 suites  ±0   35m 11s ⏱️ + 5m 57s
2 181 tests ±0  2 177 ✔️ ±0    4 💤 ±0  0 ❌ ±0 
6 633 runs  ±0  6 622 ✔️ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 8bb17f5. ± Comparison against base commit c7470b4.

♻️ This comment has been updated with latest results.

[merks]

FYI, this change is necessary because Oomph as moved the location of the encoding.info file so at this point it's arguably a bug fix.

That said, of course I do appreciate careful reviews!

[laeubi]

Looks good.

[HannesWell]

Looks good. Thanks for the follow up.

Just one minor suggestion below (but probably also a matter of taste).

[iloveeclipse]

I haven't analyzed yet, but it seems this PR might caused some severe problem, look at the test results: https://download.eclipse.org/eclipse/downloads/drops4/I20231111-0600/testResults.php

Unfortunately I only found errors that errors happen on startup, but no real log fie, see
https://download.eclipse.org/eclipse/downloads/drops4/I20231111-0600/testresults/consolelogs/ep430I-unit-macM1-java17_macosx.cocoa.aarch64_17_consolelog.txt

using launcher:  
An error has occurred. See the log file
/Users/genie.releng/workspace/AutomatedTests/ep430I-unit-macM1-java17/workarea/I20231111-0600/eclipse-testing/workspace/.metadata/.log.

[iloveeclipse]

In this log it says it can't find pde.core?

https://download.eclipse.org/eclipse/downloads/drops4/I20231111-0600/testresults/ep430I-unit-macM1-java17_macosx.cocoa.aarch64_17/directorLogs/director-org.eclipse.ant.tests.core.log

Starting application: 1334
Installing org.eclipse.ant.tests.core 3.7.200.v20230920-0631.
Installing org.eclipse.test 3.5.400.v20231108-0838.
Installing org.eclipse.ant.optional.junit 3.3.400.v20230714-1309.
Installing org.eclipse.test.performance 3.19.400.v20231108-0838.
Installing org.eclipse.test.performance.win32 3.1.600.v20230714-1309.
Installation failed.
Cannot complete the install because one or more required items could not be found.
	Software being installed: Ant Core Test Plugin 3.7.200.v20230920-0631 (org.eclipse.ant.tests.core 3.7.200.v20230920-0631)
	Missing requirement: Ant Core Test Plugin 3.7.200.v20230920-0631 (org.eclipse.ant.tests.core 3.7.200.v20230920-0631) requires 'osgi.bundle; org.eclipse.pde.core 0.0.0' but it could not be found

[merks]

I’m not sure how this can be in any way related. This method would only be used only after resolution succeeds but resolution itself is failing. And I’m very sure the method returns an empty list in an environment where oomph has not populated the user.home folder.

[iloveeclipse]

I simply don't see other changes merged...

@laeubi : any tycho / surefire updates?

[merks]

Note too in particular that only pde calls this method and only during target platform resolutions.

[laeubi]

@iloveeclipse platform uses a released version of Tycho and as far as I know the eclipse testframework uses ant/pdebuild anyways (@akurtakov ?) so I have no clue how this change or Tycho can affect this, maybe a concurrent build or network problem?

[merks]

Unless some PDE target platform resolution test is involved, it’s not even theoretically possible for the method to be called.

[merks]

Probably it’s a good idea to kick the build again.

[iloveeclipse]

Probably it’s a good idea to kick the build again.

Let see if other builds will show same issue. If not, it was a glitch in the Matrix and we can restart Mac build.

[iloveeclipse]

I see other builds were OK, so I will try to restart Mac build

[iloveeclipse]

Next build was OK. So it was some infrastructure issue...