Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tpd for defining target platform #24

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Use tpd for defining target platform #24

merged 1 commit into from
Feb 4, 2022

Conversation

dvojtise
Copy link
Contributor

@dvojtise dvojtise commented Feb 4, 2022

Description

This PR changes the way the external update sites are imported in the build.
Instead of using maven repository like:

	<repositories>
		<repository>
			<id>Eclipse release</id>
			<layout>p2</layout>
			<url>${eclipse.release.p2.url}</url>
		</repository>

It uses a tpd description file in order to generate a targetplatform file.
This tpd allows to not specify precisely the version of the imported unit while helping to control where they come from.

A readme file explains how to update the target file from the tpd (in gemoc_studio/releng/org.eclipse.gemoc.gemoc_studio.targetplatform)

NOTE: the use of the tpd is partial: the K3 and melange updatesite currently cannot be integrated in the target because these tools depends on gemoc.dsl that is actually build by GEMOC. This creates a kind of cycle in the targetplatfomr 😞 . Melange an K3 as thus still using the maven repository descriptor.

Additionally, the integration tests now explicitly use the gemoc product and target (this fix the javafx error preventing from opening the multidimentional view in the tests)

😞 I was expecting a speed up in the build (eclipse-gemoc/gemoc-studio#233) but, apparently, the newer version of tycho are optimized enough and there is no visible speed change.

Contribution to issues

Contribute to eclipse-gemoc/gemoc-studio#233

Companion Pull Requests

Signed-off-by: Didier Vojtisek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant