[Switch][Record Patterns] Unchecked conversion error missing from ECJ #3069
Commits on Oct 24, 2024
-
[Switch][Record Patterns] Unchecked conversion error missing from ECJ
+ try to balance responsibility about type checking between - Pattern.isApplicable() - don't yet report in nested position - RecordPattern.resolveType() - failed to check isApplicable() - InstanceOfExpression.resolveType() - avoid pattern-agnostic checks + added the 1st(!) test for inapplicable record pattern in switch
-
-
check all patterns via isApplicable()
+ enclosing instanceof and case stmt are responsible for its invocation + make isApplicable() more capable to issue the desired problems + let problem reporter see the error location to select problemID + more renaming for clarity Test changes: + compatibility errors more consistently mark the entire instanceof expr + remove unwanted type qualifiers + don't expect some secondary errors
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.