Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review driven incremental cleanup of sealed types implementation #3145

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Code review driven incremental cleanup of sealed types implementation #3145

merged 1 commit into from
Oct 23, 2024

Conversation

srikanth-sankaran
Copy link
Contributor

@srikanth-sankaran srikanth-sankaran commented Oct 23, 2024 •
edited
Loading

What it does

  • Get rid of dead code
  • Adopt descriptive method names
  • Overhaul switch block exhaustiveness checking
  • Fix defect that classifies switch expressions as enhanced switch statement
  • Add missing restricted keyword in JavaFeature
  • Eliminate unncessary feature level checks
  • Correct wrong diagnostics expectations in test files

How to test

Author checklist

@srikanth-sankaran srikanth-sankaran self-assigned this Oct 23, 2024
@srikanth-sankaran srikanth-sankaran added this to the 4.34 M3 milestone Oct 23, 2024
@srikanth-sankaran srikanth-sankaran merged commit 3a5cadc into eclipse-jdt:master Oct 23, 2024
10 checks passed
@srikanth-sankaran srikanth-sankaran deleted the sealed-types-cleanup branch October 23, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@srikanth-sankaran srikanth-sankaran

Labels
None yet
Projects
None yet
Milestone
4.34 M3
Development

Successfully merging this pull request may close these issues.
1 participant
@srikanth-sankaran