-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme: Removed misleading mentioning of Android Autotmotive #59
Conversation
90f1a4f
to
a3cbf9c
Compare
@SebastianSchildt Commitlint is currently failing. I can correct it if you want but a force push is necessary because the message is too long. Since we are already doing a force push, could you change the "fix" in the first commit to "docs" so this commit does not populate an entry for bug fixes. Also The commit message has to start with upper case after "docs". :) You can use a recommended branch naming like task-59 / feature-59 / fix-59 if you want this also locally checked. Don't forget to install the necessary tools defined by the repo if you want this support. ;) Last point: For traceability reasons we require a linked issue to any PR. This will result into automatic linking inside the release notes and it also clearly states the issue which needs to be fixed (Important for more complicated issues). (I can create one since I understand the issue just fine :D but just FYI).
Sounds a lot but it should just take a minute. :) Just say if you want me to correct it or do it yourself. |
Installed it already, but could not get it to run. I mean except Is there any way to just manually run the check either by piping the logs or telling it which commits to check? That would simplify things |
One more note from my side: Whatever changes are decided to be taken here, please also align the fastlane/.../full_description.txt because this is what is reflected by F-Droid and lazily copy pasted from README.md |
The reason for
|
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
a3cbf9c
to
3e39136
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Basically removed the mention about "Android Automotive" as this app does not rely in VHAL but enables KUKSA on any Android device.
Also fixed Markdown formatting/linitng issues, as it was hard to edit due to some hard linebreaks at random places