Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Don't show ConnectionStatusBar when connected #63

Merged
merged 5 commits into from
Feb 19, 2024
Merged

feature: Don't show ConnectionStatusBar when connected #63

merged 5 commits into from
Feb 19, 2024

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Feb 15, 2024 •
edited
Loading

closes: #58

@Chrylo
Copy link
Contributor

Chrylo commented Feb 15, 2024

The "connecting..." text does not seem to be centered correctly.

optional: If possible can we define a min width where the three dots are already calculated in so it does not re align always after a new dot comes in?

Chrylo

This comment was marked as outdated.

Sign in to view

Chrylo
Chrylo approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@Chrylo Chrylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The new bar layout is better :)

@Chrylo Chrylo merged commit ae270f3 into eclipse-kuksa:main Feb 19, 2024
6 checks passed
@Chrylo Chrylo deleted the feature-58 branch February 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chrylo Chrylo Chrylo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ConnectionStatusBar by something more subtle
2 participants
@wba2hi @Chrylo