Migrating Kuksa Go Client from kuksa.val #6
Conversation
To be merged after eclipse-kuksa/kuksa-incubation#6 has been merged.
To be merged after eclipse-kuksa/kuksa-incubation#6 has been merged.
erikbosch
force-pushed
the
erik_go
branch
2 times, most recently
from
ffb24e0
to
677593d
Compare
There was a problem hiding this comment.
So, the good news:
I compiled and ran agains databroker: Works
Several .go files don"t seem to be having SPDX identifiers, we should fix it, as Ihave noticed it.
Question
- shall we also add SPDX check in this repo? Even though it is incubation, projects might "graduate" out of here, and it would be a good and easy rain check to be sure, everything is "up to code" in terms of licensing at least
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. |
There was a problem hiding this comment.
SPDX identifier missing
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. |
It would be quite easy to add SPDX, I could do that |
erikbosch
force-pushed
the
erik_go
branch
2 times, most recently
from
81376d8
to
8a48bb3
Compare
|
Headers updated to match one of the models in https://www.eclipse.org/projects/handbook/#ip-copyright-headers |
|
I think the SPDX check does not understand/checks .go files crrect? https://github.com/eclipse-kuksa/kuksa-actions/blob/main/spdx/verify-spdx-headers If so, not strictly an issue with this PR, but should we repair it? |
|
Changing to draft for now to experiment with spdx checker |
erikbosch
force-pushed
the
erik_go
branch
2 times, most recently
from
cd8f018
to
a028818
Compare
|
An update to SPDX checker here: eclipse-kuksa/kuksa-actions#6 No change needed here, if we move the |
|
I merged eclipse-kuksa/kuksa-actions#6 and retagged (2 and 2.5), and retriggered the SPDX check. Looking good, but leave it up to you @erikbosch to "undraft" because not sure I missed anything |
To be merged after eclipse-kuksa/kuksa-incubation#6 has been merged.
Previously in https://github.com/eclipse/kuksa.val
For now I opted to have local copies of the proto-files, the alternative would be to have databroker as a submodule but that is maybe not that feasible for this repo.