Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Commit

Permalink
Improve printout for registered signal when using KUKSA.val Server
Browse files Browse the repository at this point in the history
No reason to give verbose information in INFO mode
Replacing f-strings with other construct
Update dependencies to hopefully fix build errors
  • Loading branch information
erikbosch committed Jul 26, 2023
1 parent e8f411d commit f0addba
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Name | Description
[SOME/IP feeder](./someip2val) | SOME/IP feeder for KUKSA.val Databroker
[DDS Provider](./dds2val) | DDS provider for KUKSA.val Databroker
[Replay](./replay) | KUKSA.val Server replay script for previously recorded files, created by providing KUKSA.val Server with `--record` argument
[CSV provider](./csv_provider) | Script to replay VSS signals to `kuksa.val` databroker as defined in a CSV-file
[CSV provider](./csv_provider) | Script to replay VSS signals to KUKSA.val Databroker as defined in a CSV-file

## Pre-commit set up
This repository is set up to use [pre-commit](https://pre-commit.com/) hooks.
Expand Down
4 changes: 4 additions & 0 deletions csv_provider/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,7 @@ so one of those names needs to be specified if connecting to `127.0.0.1`. An exa
```
python provider.py --cacertificate /home/user/kuksa.val/kuksa_certificates/CA.pem --tls-server-name Server
```

## Limitations

* CSV Provider does not support authentication, i.e. it is impossible to communicate with a Databroker that require authentication!
2 changes: 1 addition & 1 deletion dbc2val/dbcfeederlib/databrokerclientwrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

import os
import contextlib
from pathlib import Path

import grpc.aio
from pathlib import Path

import kuksa_client.grpc # type: ignore[import]
from kuksa_client.grpc import Datapoint
Expand Down
5 changes: 3 additions & 2 deletions dbc2val/dbcfeederlib/serverclientwrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,10 @@ def is_signal_defined(self, vss_name: str) -> bool:
# Check if signal is defined in server
resp = json.loads(self._kuksa.getMetaData(vss_name))
if "error" in resp:
log.error(f"Signal {vss_name} appears not to be registered: {resp['error']}")
log.error("Signal %s appears not to be registered: %s", vss_name, resp['error'])
return False
log.info(f"Signal {vss_name} is registered: {resp}")
log.info("Signal %s is registered", vss_name)
log.debug("Signal %s registration information: %s", vss_name, resp)
return True

def update_datapoint(self, name: str, value: Any) -> bool:
Expand Down
2 changes: 1 addition & 1 deletion dds2val/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# DDS Provider

The DDS provider provides data from an DDS middleware/API. For further understanding of the DDS middleware/API see [this](https://www.dds-foundation.org/what-is-dds-3/). The DDS provider only works with the KUKSA databroker. The KUKSA C++ server is not supported.
The DDS provider provides data from an DDS middleware/API. For further understanding of the DDS middleware/API see [this](https://www.dds-foundation.org/what-is-dds-3/). The DDS provider only works with the KUKSA Databroker. The KUKSA C++ Server is not supported.

## How to build

Expand Down

0 comments on commit f0addba

Please sign in to comment.