Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Upgrade to kuksa-client 0.4.0 #126

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

erikbosch
Copy link
Contributor

Using compatibility (~=0.4.0) which means that 0.4.1, 0.4.2 and so on might be downloaded, but 0.5.0 will not be accepted.

Using compatibility (~=0.4.0) which means that 0.4.1, 0.4.2 and so on might
be downloaded, but 0.5.0 will not be accepted
@erikbosch erikbosch marked this pull request as ready for review July 26, 2023 11:46

python-can ~= 4.1
pyserial ~= 3.5
cantools ~= 38.0
pyyaml ~= 6.0
can-j1939 ~= 2.0
py_expression_eval ~= 0.3
kuksa-client >= 0.4a4
kuksa-client ~= 0.4.0
Copy link
Contributor Author

@erikbosch erikbosch Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We handle versions a bit differently in our different feeders/providers. For dbc2val with the use of an *.in file we have absolute control as the generated *.txt file give exact versions. I.e. to start using kuksa-client 0.4.1 we must manually regenerate requirements.txt. For other feeders/providers we just say a compatible version and do not really control if it is 0.4.0 or 0.4.1

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Good always putting a comment wrt to putting --pre. Having this in GH should be more reliable than trusting our brains only.

@erikbosch erikbosch merged commit e8f411d into eclipse-kuksa:main Jul 26, 2023
15 checks passed
@erikbosch erikbosch deleted the erik_release branch July 26, 2023 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants