Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For issue #223 #231

Closed
wants to merge 2 commits into from
Closed

For issue #223 #231

wants to merge 2 commits into from

Conversation

vinhlq
Copy link

@vinhlq vinhlq commented Nov 21, 2021

  • In the sendPacket() function, when timer is expired mqttwrite() function is not excute. So to give it a change to send ack packet (issue Suspected bug with MQTTYield() / cycle() #223), we need to define a minimal timeout
  • The send packet timeout is defined by MIN_SEND_PACKET_TIMEOUT_MS macro

- In the sendPacket() function, when timer is expired mqttwrite() function is not excute. So to give it a change to send ack packet (issue eclipse-paho#223), we need to define a minimal timeout
- The send packet timeout is defined by MIN_SEND_PACKET_TIMEOUT_MS macro
@xw0323
Copy link

xw0323 commented Nov 29, 2021

It is a bug. Please refer to 287 line of https://github.com/evrythng/evrythng-c-library/blob/master/embedded-mqtt/MQTTClient-C/src/MQTTClient.c, and change platform_timer_countdown(&t, c->command_timeout_ms); to TimerCountdownMS(timer, c->command_timeout_ms);

@icraggs
Copy link
Contributor

icraggs commented Aug 1, 2023

We're starting to look at this project after a long interval. I intend to resolve this by taking the same approach as in the C++ client code, which is to attempt the packet send at least once. So I'll close this PR, but thank you.

@icraggs icraggs closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants