-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse existing bundle pools #875
Comments
Note that I've verified manually, by instrumenting org.eclipse.equinox.internal.p2.artifact.repository.ArtifactRequest.setSourceRepository(IArtifactRepository), that this very simple change will ensure that any artifact already available in the pool will be fetched in favor of the remote artifact. So I see what comes from the pool:
versus what comes from the remote site:
|
You are referring to #878, don't you? |
Indeed, the shared bundle pool is managed by a shared agent that manages all the profiles, i.e., of all the installer-installed installation profiles and all targlet profiles. Without such proper management, a pool would just grow indefinitely and could never be garbage collected. The shared agent itself is implemented by and managed by a large stack of technology where the bundle pool is just the tip of a vast iceberg. |
Is that technology-stack part of P2 or Oomph? |
Here is what we are talking about "migrating": It's a daunting task, with no associated funding. I'm not even convinced it's entirely sensible. Perhaps it's similar to asking m2e to migrate some parts to PDE. So far the approach there has been for m2e to provide extensions for PDE, not migrating into PDE... Perhaps PDE could provide some service, with a default implementation, that Oomph could extend to "inject" a shared agent with a shared bundle pool. I just don't know my resources are limited... |
In fact everything not maven specific is already migrated to PDE, espcially m2e was a driver for Target Editor enhancements, so in general I think its good to have as much as possible in I think Tycho (FYI @opcoach ) would be another "pool" that is suitable to be integrated here I have created for that purpose. |
Currently PDE maintains its own bundle pool in the workspace, this has many drawbacks:
PDE should have some mean to access existing well known pools of P2 items to leverage already downloaded content. As we have hashes + signatures if in doubt one could even verify that data from such pools is "true"...
The text was updated successfully, but these errors were encountered: