-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Oomph's bundle pools to PDE's artifact repositories for resolution #878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
I thought about that already multiple times too and assumed that this couldn't be that hard but I'm surprised that it is that easy (you just have to know how 😄)
ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/P2TargetUtils.java
Outdated
Show resolved
Hide resolved
Test Results 264 files - 6 264 suites - 6 41m 31s ⏱️ - 11m 8s For more details on these failures, see this check. Results for commit 5c54fd8. ± Comparison against base commit 84b2e1e. ♻️ This comment has been updated with latest results. |
b6069bb
to
aa18231
Compare
ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/P2TargetUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you.
For clarification: with this change PDE only re-uses artifacts from the shared bundle-pool in the user.home if they are present, but does not add missing ones, doesn't it?
So I would say this is a good step towards #875, but not a full resolution?
I'm not sure what you mean by "missing ones". Oomph only has a single shared agent manager that is always located in ~/.p2. There is a fair bit more flexibility to the agent manager than that, but I expect pretty much no one in the world is using multiple agents. So I'm not sure what important thing you think might be missing. |
Artifacts not yet in the pool, that are included in a target and would need to be added to the pool. |
Yes, it only allows p2 to read from the artifact/bundle pool, exactly like it does for all the other artifact repository URIs that are added by the existing artifact repository gathering logic. PDE would need some major design changes and restructuring before it could be reasonably trusted (by me) to write into and reuse the shared bundle pool. For me, if that pool is corrupted, it would destroy more than 100 installations/workspaces. |
Yes, I just wanted to make it clear (for myself and others) what this change is exactly doing. :) |
It does only exactly what the title says. 😁 |
#875