Add Oomph's bundle pools to PDE's artifact repositories for resolution

[merks]

#875

[HannesWell]

Very nice!
I thought about that already multiple times too and assumed that this couldn't be that hard but I'm surprised that it is that easy (you just have to know how 😄)

[github-actions]

Test Results

   264 files   -        6     264 suites   - 6   41m 31s ⏱️ - 11m 8s
3 328 tests +       1  3 297 ✔️ ±       0  30 💤 ±  0  1 ❌ +1 
7 557 runs   - 2 721  7 490 ✔️  - 2 698  66 💤  - 24  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 5c54fd8. ± Comparison against base commit 84b2e1e.

♻️ This comment has been updated with latest results.

[HannesWell]

Looks good. Thank you.

For clarification: with this change PDE only re-uses artifacts from the shared bundle-pool in the user.home if they are present, but does not add missing ones, doesn't it?

So I would say this is a good step towards #875, but not a full resolution?

[merks]

I'm not sure what you mean by "missing ones". Oomph only has a single shared agent manager that is always located in ~/.p2. There is a fair bit more flexibility to the agent manager than that, but I expect pretty much no one in the world is using multiple agents. So I'm not sure what important thing you think might be missing.

[HannesWell]

I'm not sure what you mean by "missing ones".

Artifacts not yet in the pool, that are included in a target and would need to be added to the pool.

[merks]

Yes, it only allows p2 to read from the artifact/bundle pool, exactly like it does for all the other artifact repository URIs that are added by the existing artifact repository gathering logic.

PDE would need some major design changes and restructuring before it could be reasonably trusted (by me) to write into and reuse the shared bundle pool. For me, if that pool is corrupted, it would destroy more than 100 installations/workspaces.

[HannesWell]

PDE would need some major design changes and restructuring before it could be reasonably trusted (by me) to write into and reuse the shared bundle pool. For me, if that pool is corrupted, it would destroy more than 100 installations/workspaces.

Yes, I just wanted to make it clear (for myself and others) what this change is exactly doing. :)

[merks]

PDE would need some major design changes and restructuring before it could be reasonably trusted (by me) to write into and reuse the shared bundle pool. For me, if that pool is corrupted, it would destroy more than 100 installations/workspaces.

Yes, I just wanted to make it clear (for myself and others) what this change is exactly doing. :)

It does only exactly what the title says. 😁