Packages/bundles that are already imported/added are shown

[lathapatil]

Packages/bundles that are already imported/added are shown followed by [already imported/added]

Fixes #146

[gireeshpunathil]

@lathapatil - did change set from #1194 carry over into this PR?

[lathapatil]

@lathapatil - did change set from #1194 carry over into this PR?

No, I am trying to figure out what went wrong. Looks like #1194 has not reached here along with its branch !

[github-actions]

Test Results

   279 files   - 1     279 suites   - 1   45m 15s ⏱️ - 6m 33s
 3 586 tests ±0   3 509 ✅  - 1   76 💤 ±0  1 ❌ +1 
10 756 runs   - 2  10 553 ✅  - 3  202 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 15a6239. ± Comparison against base commit b29e97a.

♻️ This comment has been updated with latest results.

[gireeshpunathil]

it is probably because you branched out for this PR from the previous branch, so the tip of the branch got carried over.

nothing to worry: I will help you fix that. if you are using command line then do this:

• git rebase -I HEAD~2
• this opens up the commit editor in vim editor
• you will see 2 entries for the two commits.
• remove the line that has 214071f in the commit hash
• save and close
• git push -f <origin branch> < this pr branch>

[lathapatil]

it is probably because you branched out for this PR from the previous branch, so the tip of the branch got carried over.

Yes. Thanks for the support .
I am using EGit and working in windows OS for PDE . I was able to fix this issue using EGit interactive rebase.

[lathapatil]

@laeubi Could you please test the PR if it meets the expectations and possibly review the code ?

[laeubi]

@lathapatil do I need to consider something special?

I fetched this PR then started an embedded workbench and tried the following:

but package aQute.bnd.build is not shown.

I also think it would be good to have a checkbox (enabled by default) "Show already imported packages", at best the user choice is persisted to survive a restart.

[lathapatil]

I fetched this PR then started an embedded workbench and tried the following:

After checking out the pull request (PR) while in PDE workspace , switch to the PR branch and launch the Eclipse application. Then, create a plugin project and inspect the manifest file for imported packages, required bundles, and exported packages.

This is what I have attempted, and the changes are visible.

What do you mean by embedded workbench ?

[lathapatil]

I also think it would be good to have a checkbox (enabled by default) "Show already imported packages"

This is already part of the PR. But I observed there is some delay in loading all packages

[lathapatil]

Please find attached video for working of the feature from the branch https://github.com/lathapatil/eclipse.pde/tree/Issues/146_Show_imported_exported_required_bundles

2024-04-09_15h43_11.mp4

[lathapatil]

@laeubi could you please try testing and reviewing this ?
@gireeshpunathil Can you please try to test this .. if you are also not able to see the changes

[gireeshpunathil]

@lathapatil - sure, will do. also, could you pls rebase your changes? as it was quite some time, now there is a conflict that has emerged.

[lathapatil]

@lathapatil - sure, will do. also, could you pls rebase your changes? as it was quite some time, now there is a conflict that has emerged.

Now it is rebased with conflicts resolved. Could you please verify the behavior

[gireeshpunathil]

@lathapatil - thanks, I tested this and found two minor issues. not sure if you want to fix it in this PR or another one:

• when I select plugins or packages that are already in and not already in together, then the add button is ON. puzzled on what would be the right behaviour!

• export packages section is showing empty, even when I have one. your video shows it right, however. so I am wondering what would be the difference between the environment of yours and mine!

[lathapatil]

• puzzled on what would be the right behaviour!

in my opinion enabling ADD button is valid because user have selected one which is not added yet in the multiple selection and only that will be added as a result. It is mentioned here as well

• export packages section is showing empty, even when I have one. your video shows it right, however. so I am wondering what would be the difference between the environment of yours and mine!

I found one bug in this and fixed please take latest commit .
I get some packages to export because I have some non-empty packages in my plugin project whose manifest file we are operating on.

[gireeshpunathil]

@lathapatil - I tested the new changes, and it works fine, as you have showed in the video. thanks!