Various improvements of the TP-Editor's content-assist #1449
+176
−279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
HannesWell
commented
Oct 18, 2024
HannesWell
commented
- Make RepositoryCache static instead of singleton
- Consider all repositories of location for proposals
- Completely parallelize P2 metadata fetching
laeubi
reviewed
Oct 19, 2024
...nsion/src/org/eclipse/pde/internal/genericeditor/target/extension/model/RepositoryCache.java
Outdated
Show resolved
Hide resolved
laeubi
reviewed
Oct 19, 2024
...nsion/src/org/eclipse/pde/internal/genericeditor/target/extension/model/RepositoryCache.java
Outdated
Show resolved
Hide resolved
laeubi
reviewed
Oct 19, 2024
| Map<String, List<IVersionedId>> map = toSortedMap(P2Fetcher.fetchAvailableUnits(r)); | ||
| future.complete(map); | ||
| }); | ||
| job.setUser(true); |
There was a problem hiding this comment.
I think Jobs should have a group here as there could be many of them.
There was a problem hiding this comment.
I tried that but in the UI I couldn't see a difference and in code it's not needed, since the joint completion is handled via the Future. Therefore I cannot see a real advantage here.
What also should be considered that at maximum all declared repos of a location are queried in parallel.
So I assume the number of parallel jobs not to be too great.
HannesWell
force-pushed
the
tp-editor-content-assist
branch
2 times, most recently
from
b92ac06
to
cb1a9df
Compare
And remove the 'flush' parameter from RepositoryCache.fetchP2UnitsFromRepo(), because this method is only called with 'flush=true' if the repository is not 'up-to-date' and therefore no data are available any ways. Furthermore make RepositoryCache thread-safe.
And use the parsed location URI of a repository as cache-key.
HannesWell
force-pushed
the
tp-editor-content-assist
branch
from
cb1a9df
to
09c6419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.