Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builds] Remove elements unnecessary with the new version-bump workflow #2387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .github/workflows/updateRelease.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,6 @@ jobs:
mvn -U -Pbuild-individual-bundles -ntp
org.eclipse.tycho:tycho-versions-plugin:set-version -DnewVersion=${{ github.event.milestone.title }}.0-SNAPSHOT
org.eclipse.tycho:tycho-versions-plugin:set-parent-version -DnewParentVersion=${{ github.event.milestone.title }}.0-SNAPSHOT
- name: Build and Bump Versions
uses: Wandalen/wretry.action@6feedb7dedadeb826de0f45ff482b53b379a7844 # master
with:
attempt_delay: 120000
attempt_limit: 10
command: >-
mvn -U -Pbuild-individual-bundles -ntp
clean verify
-DskipTests
-Dcompare-version-with-baselines.skip=false
org.eclipse.tycho:tycho-versions-plugin:bump-versions -Dtycho.bump-versions.increment=100
- name: Create Pull Request for Release ${{ github.event.milestone.title }}
uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # v7.0.5
with:
Expand Down
26 changes: 0 additions & 26 deletions eclipse-platform-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -774,32 +774,6 @@
</repository>
</repositories>
</profile>
<profile>
<!-- This provile enables automatic version bumps when running the build -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned last time this can be used locally as well, so I would prefer to keep the profile

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it can be used. But I wonder if it is really used by a relevant number of people?
Personally I have never used it and didn't even know about before working in this area. Do you use it or know anybody that uses it?

Now that we have it automated at GH, I think this particular profile became even less relevant.

<id>vb</id>
<properties>
<compare-version-with-baselines.skip>false</compare-version-with-baselines.skip>
</properties>
<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-versions-plugin</artifactId>
<executions>
<execution>
<id>bump</id>
<goals>
<goal>bump-versions</goal>
</goals>
<configuration>
<increment>100</increment>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>build-individual-bundles</id>
<activation>
Expand Down