Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debian stable based image to build swt natives #2441

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Oct 8, 2024

Currently we build the swt natives with centos-8 but this is now gone,
also centos-9 no longer provides stable releases but only
rolling-streams,

This adds a new container based on debian stable and only adds the
absolute minimum required to build the swt natives.

Why Debian:

Debian offers quite conservative dependencies and LTS releases
so there is a good chance to have a common baseline that works on
more ahead distributions as well (e.g. GClib /GTK/... versions).

@akurtakov
Copy link
Member

Can you build swt gtk4 on it ? I don't think doing any switch that doesn't allow that is worth the effort.

@laeubi
Copy link
Contributor Author

laeubi commented Oct 8, 2024

Can you build swt gtk4 on it ?

No gtk4 will require debian-stable (not old stable), but this will raise the Glibc requirement considerably..

I don't think doing any switch that doesn't allow that is worth the effort.

We currently build on an image we can't actively change nor can get any patches anymore, we can't build it even in the current state. So my fist goal would be to get into a working state again where we have the chance to update.

@akurtakov
Copy link
Member

Please note that changing the image may raise in some other way (glibc/cairo/.....) and introduce breakage (and extra work - e.g. simrel projects no longer build and test with default image centos) while there is no gain from it. I don't mind the change in principle just looking for some benefit when introducing potential extra work.
My vote is "0" on it :).

@laeubi
Copy link
Contributor Author

laeubi commented Oct 8, 2024

Please note that changing the image may raise in some other way (glibc/cairo/.....) and introduce breakage (and extra work - e.g. simrel projects no longer build and test with default image centos)

That's why I previously waited for the ubuntu image to be available. At some point we need to start breaking things, so for me it looks more useful to slowly raise the barrier than requiring a big jump in dependencies at once.

@laeubi
Copy link
Contributor Author

laeubi commented Oct 8, 2024

BTW oldstable is currently GLIBC 2.31-13

@laeubi
Copy link
Contributor Author

laeubi commented Oct 9, 2024

I now moved to debian-stable what supports gtk4 (4.8.3) and uses glibc 2.36-9 with that I can compile the GTK4 binaries when apply this PR:

@laeubi laeubi changed the title Add debian oldstable based image to build swt natives Add debian stable based image to build swt natives Oct 9, 2024
@akurtakov
Copy link
Member

I now moved to debian-stable what supports gtk4 (4.8.3) and uses glibc 2.36-9 with that I can compile the GTK4 binaries when apply this PR:

* [Make new GTK4 Dialog dynamic loaded for pre GTK 4.10 eclipse.platform.swt#1519](https://github.com/eclipse-platform/eclipse.platform.swt/pull/1519)

FWIW, binaries produced that way will run just fine on distro having GTK 4.10+ e.g. Ubuntu 24.04 so it is a good first step.

Currently we build the swt natives with centos-8 but this is now gone,
also centos-9 no longer provides stable releases but only
rolling-streams,

This adds a new container based on debian stable and only adds the
absolute minimum required to build the swt natives.

Why Debian:
 Debian offers quite conservative dependencies and LTS releases
 so there is a good chance to have a common baseline that works on
 more ahead distributions as well (e.g. GClib /GTK/... versions).
@laeubi laeubi merged commit b3367b4 into eclipse-platform:master Oct 9, 2024
3 of 4 checks passed
@laeubi
Copy link
Contributor Author

laeubi commented Oct 9, 2024

Unluckily the push fails, I created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants