Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Replace use of coactions/setup-xvfb #1492

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[Build] Replace use of coactions/setup-xvfb #1492

merged 2 commits into from
Oct 16, 2024

Conversation

HannesWell
Copy link
Member

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

Test Results

   486 files  ±0     486 suites  ±0   8m 39s ⏱️ +41s
 4 154 tests ±0   4 146 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 370 runs  ±0  16 278 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit 9a66fef. ± Comparison against base commit 209d75a.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the replace-setup-xvfb branch 2 times, most recently from bebd822 to 37d346a Compare September 26, 2024 20:02
@HannesWell
Copy link
Member Author

The tests fail on Linux although XVFB is now available by default on the Linux runners:
https://github.com/actions/runner-images/blob/ubuntu22/20240922.1/images/ubuntu/Ubuntu2204-Readme.md

@HannesWell
Copy link
Member Author

@akurtakov do you have any idea why this fails with the preinstalled xvfb on gtk.linux.x86_64-java17?
According to the list of installed software it's available:
https://github.com/actions/runner-images/blob/ubuntu22/20240922.1/images/ubuntu/Ubuntu2204-Readme.md

Could there be a version problem?

@HannesWell HannesWell mentioned this pull request Oct 15, 2024
Merged
@laeubi
Copy link
Contributor

laeubi commented Oct 16, 2024

See my comment here

xvfb is installed that does not mean it works by simply doing nothing.... one has to use xvfb-run <command> (of course only on linux) and somehow make it work/skip on windows, so I think the calim is wrong that the action is no longer needed, it would just not be needed to install xvfb.

@HannesWell HannesWell force-pushed the replace-setup-xvfb branch 2 times, most recently from daf4b2a to bb44f9a Compare October 16, 2024 18:26
@HannesWell
Copy link
Member Author

HannesWell commented Oct 16, 2024 •
edited
Loading

xvfb is installed that does not mean it works by simply doing nothing.... one has to use xvfb-run <command> (of course only on linux) and somehow make it work/skip on windows, so I think the calim is wrong that the action is no longer needed, it would just not be needed to install xvfb.

Now that you have said it totally makes sense and it's obvious that it wasn't working with the initial attempt 🤦🏽‍♂️.
Thanks for pointing this out!

In order to just prepend the xvfb-run command only on Linux I have used the 'ternay' operator for the GH action syntax:
${{ startsWith(matrix.config.native, 'gtk') && 'xvfb-run' || '' }}

With that the Linux build now succeeds again without any test-failure.

@HannesWell
[Build] Remove unnecessary build arguments in GH workflow
6bde31b 
The propertiy 'compare-version-with-baselines.skip' is true by default.
@HannesWell
[Build] Replace use of coactions/setup-xvfb
9a66fef 
Because GH workflows running on Windows by default use 'PowerShell Core'
as shell all arguments that contain a dot have to be quoted because
powershell interprets dots.
Running SWT on a 'CMD' shell breaks some tests.
@HannesWell
Copy link
Member Author

Finally also the Windows workflow passes all tests. For some reasons, when using the CMD shell some tests fail. So I quoted all parameters that contain a dot so that powershell (the default shell for Windows) does not interpret them.

@HannesWell
Copy link
Member Author

Test failures in Jenkins are unrelated, submitting.

@HannesWell HannesWell merged commit eb9e8d6 into eclipse-platform:master Oct 16, 2024
10 of 14 checks passed
@HannesWell HannesWell deleted the replace-setup-xvfb branch October 16, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HannesWell @laeubi