-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Extend Browser API to check for custom text location" #1533
Revert "Extend Browser API to check for custom text location" #1533
Conversation
@HeikoKlare Do we need to do another version bump? |
Test Results 486 files ± 0 486 suites ±0 7m 28s ⏱️ -49s Results for commit 7fbee5e. ± Comparison against base commit 8ce60f9. This pull request removes 5 tests.
♻️ This comment has been updated with latest results. |
639fa7b
to
acb2b9b
Compare
This reverts public API introduced in the last release. It is not very likely anyone has adopted that yet but I don't think we can simply revert this now. In fact, the API tools should suggest a major version bump for this change - not sure why this is not the case (or I am just missing it?) |
It has been introduced after the last release for M1, so it should be safe to revert now, shouldn't it? |
Ah, you're right. Yes, then it's perfectly fine to revert now without a version bump. And yes, we should do so as early as possible to get this into M2. |
acb2b9b
to
f8a7c72
Compare
3 new issues of type |
This reverts commit 51b8d8f. The API isLocationForCustomText is not needed for Browsers. contributes to eclipse-platform#213
f8a7c72
to
7fbee5e
Compare
Recent master build now shows the same number of issues than in this PR, but Jenkins still compares builds for this PR against previous master build: |
This reverts commit 51b8d8f. The API isLocationForCustomText is not needed for Browsers.
contributes to #213