Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32: Update search for AllowDarkModeForWindowWithTelemetryId for 24H2 #1547

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

sratz
Copy link
Member

@sratz sratz commented Oct 21, 2024

Fixes #1546

@sratz
Copy link
Member Author

sratz commented Oct 21, 2024

This validation approach is rather fragile...

So far the exports' ordinals

  • 133 = AllowDarkModeForWindow
  • 135 = SetPreferredAppMode
  • 140 = AllowDarkModeForWindowWithTelemetryId

have not ever changed and I wonder If they ever will.

Maybe we should be more relaxed with the validation. Then, on the other hand, if they would, we'd probably end up crashing the application.

Copy link
Contributor

github-actions bot commented Oct 21, 2024

Test Results

   486 files  ±0     486 suites  ±0   6m 29s ⏱️ - 2m 34s
 4 154 tests ±0   4 146 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 370 runs  ±0  16 278 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit 8284de6. ± Comparison against base commit 18a9adb.

♻️ This comment has been updated with latest results.

@sratz sratz merged commit 67402fd into master Oct 23, 2024
14 checks passed
@sratz sratz deleted the win32_24h2_dark branch October 23, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eclipse having problem with dark theme on newer Windows 11 24H2
1 participant