-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #48 FileDialog created displays error if no fileFilter Path set #229
Issue #48 FileDialog created displays error if no fileFilter Path set #229
Conversation
272353b
to
80c4069
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified using Snippet 48, ClipboardExample "Choose file" dialog and TextEditor.java "Open" feature. Issue is fixed.
/rebase |
80c4069
to
4e01b41
Compare
This feels more like workaround rather than bugfix. IMHO a better fix would be needed that properlty sets the chooser up to not require this hack. Can you reproduce the issue in pure C code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it looks like you changed way more files as needed, most likely due some bad merge operation.
Please only push one commit with only changes you really wanted to make.
b2f6475
to
ae20b22
Compare
…or if no FilterPath set +if no filename set defaults to location of file The issue was caused by if no filename was set then it would try to open file "" as a default which creates an error. This is simply fixed by if no filename is set then set the filename to location of the file Signed-off-by: Jason Wang <[email protected]>
ae20b22
to
a14c9e3
Compare
@iloveeclipse as @jasonhy-wang rebased properly I'll dismiss your change request to not block it further. |
Works just fine as tested on Gtk 4.x locally. |
+if no filename set defaults to location of file
The issue was caused by if no filename was set then it would try to open file "" as a default which creates an error. This is simply fixed by if no filename is set then set the filename to location of the file
Signed-off-by: Jason Wang [email protected]
Original Issue #48