Issue #48 FileDialog created displays error if no fileFilter Path set #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonhy-wang
requested review from
sravanlakkimsetti and
akurtakov
as code owners
jasonhy-wang
force-pushed
the
fileDialogError
branch
from
272353b
to
80c4069
Compare
joel-majano
approved these changes
Jun 23, 2022
|
/rebase |
github-actions
bot
force-pushed
the
fileDialogError
branch
from
80c4069
to
4e01b41
Compare
|
This feels more like workaround rather than bugfix. IMHO a better fix would be needed that properlty sets the chooser up to not require this hack. Can you reproduce the issue in pure C code? |
jasonhy-wang
requested review from
lshanmug,
niraj-modi and
iloveeclipse
as code owners
iloveeclipse
previously requested changes
Jul 26, 2022
jasonhy-wang
force-pushed
the
fileDialogError
branch
from
b2f6475
to
ae20b22
Compare
…or if no FilterPath set +if no filename set defaults to location of file The issue was caused by if no filename was set then it would try to open file "" as a default which creates an error. This is simply fixed by if no filename is set then set the filename to location of the file Signed-off-by: Jason Wang <[email protected]>
akurtakov
force-pushed
the
fileDialogError
branch
from
ae20b22
to
a14c9e3
Compare
|
@iloveeclipse as @jasonhy-wang rebased properly I'll dismiss your change request to not block it further. |
akurtakov
approved these changes
Aug 2, 2022
|
Works just fine as tested on Gtk 4.x locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+if no filename set defaults to location of file
The issue was caused by if no filename was set then it would try to open file "" as a default which creates an error. This is simply fixed by if no filename is set then set the filename to location of the file
Signed-off-by: Jason Wang [email protected]
Original Issue #48