Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTK4] Initial clipboard port fixes + TextTransfer fix #35

Merged
merged 2 commits into from
Apr 20, 2022
Merged

[GTK4] Initial clipboard port fixes + TextTransfer fix #35

merged 2 commits into from
Apr 20, 2022

Conversation

joel-majano
Copy link
Contributor

@joel-majano joel-majano commented Apr 8, 2022 •
edited
Loading

Opened issue #34 for this fix, but potentially not the final TextTransfer fix.

  • Intial removal of GdkAtom related function calls
  • removed some function calls that aren't needed in GTK4
  • Cleanup of getTypeNames/getTypeIds for TextTransfer
  • added getContents_gtk4 to handle fetching of clipboard contents (supports TextTransfer now)
  • added setData_gtk4 to handle setting of clipboard (supports TextTransfer now)
  • added GdkClipboard functions in GTK4.java and some GValue functions in OS.java
  • added Comments on some functions that require GTK4 porting

Tested using ClipboardExample.

akurtakov
akurtakov reviewed Apr 18, 2022
View reviewed changes
bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/gtk/org/eclipse/swt/dnd/Clipboard.java Outdated
C.memset (value, 0, OS.GValue_sizeof ());

//Pasting of text (TextTransfer)
if(transfer.getTypeNames()[0] == "STRING") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String comparison should happen with .equals not with ==

@akurtakov akurtakov merged commit 5c13ae0 into eclipse-platform:master Apr 20, 2022
@akurtakov akurtakov added the Linux/GTK Happens on Linux label Apr 20, 2022
@joel-majano joel-majano deleted the clipboard-fix-1 branch June 23, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurtakov akurtakov akurtakov left review comments

Assignees
No one assigned
Labels
Linux/GTK Happens on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joel-majano @akurtakov