SearchHistoryMenu: improve scrolling through selection with arrow keys #2232
Conversation
There was a problem hiding this comment.
Wouldn't it also be an option to set the selection to the first (or even to the currently selected, if existing) entry in the table? Then you would always have a selection and do not require this additional functionality replicating the complete navigation functionality.
Note that in usual dropdowns, hovering over other elements also moves the selection to these entries, so that the keyboard navigation will proceed from the entry you have hovered over last.
...rkbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/SearchHistoryMenu.java
Outdated
Show resolved
Hide resolved
Wittmaxi
force-pushed
the
MW_dropdown_navigate_to_first
branch
2 times, most recently
from
3a159e7
to
7ad0aad
Compare
|
The hover is now sticky such that the navigation with the arrow keys resumes from the position where the last hover happened. That way, I could fix the comment about using the adapter for the listener on the fly. |
...rkbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/SearchHistoryMenu.java
Show resolved
Hide resolved
Wittmaxi
force-pushed
the
MW_dropdown_navigate_to_first
branch
from
7ad0aad
to
b6186f5
Compare
|
@HeikoKlare if this is fine with you, I will merge by end of day |
|
Verified on the below build applying the pr and i am able to select 1st entry when using down arrow key on Find/replace overlay. Eclipse SDK |
HeikoKlare
force-pushed
the
MW_dropdown_navigate_to_first
branch
from
b6186f5
to
be6e21b
Compare
Scrolling through the selection of the Search History now correctly starts at the first item and cycles through the boundaries (ie. scrolling down from the last item returns correctly to the first item of the list) fixes eclipse-platform#2139
HeikoKlare
force-pushed
the
MW_dropdown_navigate_to_first
branch
from
be6e21b
to
ad27024
Compare
Scrolling through the selection of the Search History now correctly starts at the first item and cycles through the boundaries (ie. scrolling down from the last item returns correctly to the first item of the list)
fixes #2139