[Sticky Scrolling] Fix "Show line numbers" settings is not correctly handled #2328
+26
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christopher-Hermann
changed the title
|
#2266 must be merged first |
BeckerWdf
approved these changes
Sep 26, 2024
Christopher-Hermann
force-pushed
the
lineNumberFix
branch
2 times, most recently
from
14eff16
to
04e7453
Compare
When changing the "Show line numbers" setting for the editor, the sticky scrolling control should also react on the setting and hide the line numbers. Fixes eclipse-platform#2269
Christopher-Hermann
force-pushed
the
lineNumberFix
branch
from
04e7453
to
ed04e04
Compare
Christopher-Hermann
merged commit 62abff0
into
eclipse-platform:master
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing the "Show line numbers" setting for the editor, the sticky scrolling control should also react on the setting and hide the line numbers.
Fixes #2269
Retest
Enable sticky scrolling and open a java class. Ensure that a sticky line is visible. Change the "Show line numbers" settings in the Text Editor settings and check that the sticky scrolling rendering is adapted accordingly.
