Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StickyScrolling] Move complex line adaption to central handler #2399

Conversation

Christopher-Hermann
Copy link
Contributor

Move the adaption of the sticky lines to the growing sticky lines control into the central handler class. This change simplifies the sticky lines provider, making implementations for specific languages more straightforward and maintainable.

Preparation for #2398

@Christopher-Hermann Christopher-Hermann self-assigned this Oct 14, 2024
Copy link
Contributor

github-actions bot commented Oct 14, 2024

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 35m 12s ⏱️ -11s
 7 711 tests +2   7 482 ✅ +1  228 💤 ±0  1 ❌ +1 
24 294 runs  +6  23 546 ✅ +5  747 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit d22b414. ± Comparison against base commit d6a50a4.

This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testRemoveStickyLines
org.eclipse.ui.internal.texteditor.stickyscroll.DefaultStickyLinesProviderTest ‑ testSourceViewerWithDifferentModelAndWindgetLines
org.eclipse.ui.internal.texteditor.stickyscroll.StickyScrollingControlTest ‑ testShowStickyLineTextsWithSourceViewerMapping
org.eclipse.ui.internal.texteditor.stickyscroll.StickyScrollingHandlerTest ‑ testDontCalculateStickyLinesForFirstLine
org.eclipse.ui.internal.texteditor.stickyscroll.StickyScrollingHandlerTest ‑ testLineUnderStickyLine
org.eclipse.ui.internal.texteditor.stickyscroll.StickyScrollingHandlerTest ‑ testRemoveStickyLines

♻️ This comment has been updated with latest results.

Move sticky lines adaptation to the growing sticky lines control into the central sticky scrolling handler. This change simplifies the sticky lines provider, making implementations for specific languages more straightforward and maintainable.

Preparation for eclipse-platform#2398
@Christopher-Hermann
Copy link
Contributor Author

Failing test is unrelated...

@Christopher-Hermann Christopher-Hermann merged commit 5c9af91 into eclipse-platform:master Oct 25, 2024
15 of 17 checks passed
@Christopher-Hermann Christopher-Hermann deleted the stickyScrollingRef1 branch October 25, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants