-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAC] - Light(Preview) theme - Fix for missing alternate row colors for Tree #2404
base: master
Are you sure you want to change the base?
[MAC] - Light(Preview) theme - Fix for missing alternate row colors for Tree #2404
Conversation
@@ -126,6 +125,11 @@ CTabFolder Canvas { | |||
background-color: #f8f8f8; | |||
} | |||
|
|||
.View Composite Tree{ | |||
background-color: #f8f8f8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on macOS.
Zebra-Lines are not visible because of this line. If this is removed. Zebar-Lines are visible.
@@ -126,6 +125,11 @@ CTabFolder Canvas { | |||
background-color: #f8f8f8; | |||
} | |||
|
|||
.View Composite Tree{ | |||
background-color: #f8f8f8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background-color: #f8f8f8; |
946ba25
to
00e7413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
00e7413
to
28b2a1f
Compare
You are right. So they requirement would be: Show the zebra-lines in Trees but only when the tree has more then one column. Correct? |
Yes |
Actually zebra lines are only visible when |
@@ -195,6 +194,10 @@ CTabFolder Canvas { | |||
background-color: #ffffff; | |||
} | |||
|
|||
#org-eclipse-ui-navigator-ProjectExplorer Tree{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should reference concrete views of the Eclipse SDK.
Do it get it right: Mac creates these zebra lines for trees only if they have more then two "columns"? Is that a feature of the native UI toolkit or is this controlled by the SWT implementation? Is it correct that setting background color does overwrite the "show visible lines" setting? Is that think that is controlled by the SWT implementation? Do we have a possibility to tell SWT so set the background only if "show visible lines" is false / if the tree as more then two "columns"? |
No. Zebra lines are only visible when |
Below is my understanding Light theme Light (Preview) theme
Project explorer, Outline View - Tree Control - has only one column - bg color is grey - setLinesVisible is false |
28b2a1f
to
8013b72
Compare
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
On macOS setting "linesVisible" to true creates an zebra styled pattern on the tree. If we now set the background color via CSS on this tree that pattern would be gone. Setting the background color via CSS on a tree that has "linesVisible" to false does not do any harm.
ee04e52
to
4d7d8a2
Compare
I just pushed a fix for this. |
Tested, and I see zebras. 🦓 🦓 🦓 🦓 Thanks! |
Tree Viewers had alternate row colors if they had coloumns, in Light Theme. This was missing in Light(Preview) theme. This has been fixed with this change by making swt-lines-visible (Tree Property) to true.
Please refer #2395