-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FindNextAction] synchronize search history with FindReplaceOverlay #2405
base: master
Are you sure you want to change the base?
Conversation
b8a90a9
to
ef096fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sharing the settings between the dialog and the overlay is good. The current proposal will produce a regression in the dialog, which needs to be resolved.
fDialogSettings= settings.getSection(FindReplaceDialog.class.getName()); | ||
if (fDialogSettings == null) | ||
fDialogSettings= settings.addNewSection(FindReplaceDialog.class.getName()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break the FindReplaceDialog
, as it still uses the subsection according to its class name. Shouldn't we use a subsection in the dialog settings of the bundle, e.g., using the class name of the FindReplaceAction
class, like done with the FindReplaceDialog
before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made it so that FindReplaceDialog, FindReplaceOverlay and FindNextAction have the exact same method for getting the Dialog Settings in 5847b3d
I have contemplated adding this as a public method to the FindReplaceAction, however I chose not to in order not to pollute API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wittmaxi Now you extract different settings sections, as each class (the action, overlay and dialog) retrieve the one according their own class instead of the one for the same class (such as the action):
IDialogSettings dialogSettings = settings.getSection(getClass().getName());
ef096fd
to
5847b3d
Compare
5847b3d
to
187a555
Compare
187a555
to
048dbb0
Compare
…ipse-platform#2285 Synchronize search history with the FindReplaceOverlay, FindReplaceDialog and FindNextAction. Fixes eclipse-platform#2285
048dbb0
to
0cd7720
Compare
synchronize search history with the FindReplaceOverlay and FindReplaceDialog.
This fix is not as extensive as a prior attempt (#2308) and thus does not require as much testing. Since this is a high-priority issue, we want this to be fixed ASAP.