Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable all breakpoints bugfix #1584

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Disable all breakpoints bugfix #1584

merged 2 commits into from
Oct 11, 2024
+12 −1

Conversation

SougandhS
Copy link
Contributor

Fix for #1583

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 28m 6s ⏱️ - 13m 55s
 4 170 tests ±0   4 148 ✅ +1   22 💤 ±0  0 ❌  - 1 
13 107 runs  ±0  12 943 ✅ +1  164 💤 ±0  0 ❌  - 1 

Results for commit 43d7300. ± Comparison against base commit 6887f61.

♻️ This comment has been updated with latest results.

@SougandhS
Copy link
Contributor Author

Hi @jukzi
Could you please check on this ?

jukzi
jukzi approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@jukzi jukzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could be improved but it is also fine as is

@SougandhS SougandhS requested a review from jukzi October 11, 2024 08:56
@SougandhS SougandhS force-pushed the DisableAllBreakpoints_MinorBugFix branch from 3863bee to 16d8571 Compare October 11, 2024 10:02
@SougandhS SougandhS requested a review from jukzi October 11, 2024 10:17
@jukzi
Copy link
Contributor

jukzi commented Oct 11, 2024

Thanks.

@SougandhS
Copy link
Contributor Author

Thanks.

Thanks for the analysis

@jukzi jukzi merged commit 7fa51b7 into eclipse-platform:master Oct 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jukzi jukzi Awaiting requested review from jukzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SougandhS @jukzi