ConfigurationUtility.isMethodOverwrite inefficient reflection #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolobazzi
force-pushed
the
features/pbz/24.2/configutil-method-override
branch
4 times, most recently
from
fffc854
to
79651b0
Compare
Add lazy initialized cache for declared methods for each queried class. Additionally fetching all declared methods of a class avoids catching NoSuchMethodExceptions when trying to find a method. 359087
paolobazzi
force-pushed
the
features/pbz/24.2/configutil-method-override
branch
from
79651b0
to
85000fc
Compare
mvilliger
reviewed
Sep 2, 2024
| assertNotNull(methodName, "methodName must not be null"); | ||
| Method declaredMethod = getDeclaredMethod(declaringType, methodName, parameterTypes); | ||
| if (declaredMethod == null) { | ||
| LOG.error("cannot find declared method {}.{}", declaringType.getName(), methodName); |
There was a problem hiding this comment.
Is log level error really correct? Maybe warn should be sufficient?
| } | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
We could also introduce a cache for the method signature (declaring class, name, param types). Then the search loop would no longer be necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lazy initialized cache for declared methods for each queried class. Additionaly fetching all declared methods of a class avoids catching NoSuchMethodExceptions when trying to find a method.
359087