ServiceOperationInvoker#getValidatedServiceAccess inefficient reflection #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolobazzi
force-pushed
the
features/pbz/24.2/359668-service-invoker-reflection
branch
2 times, most recently
from
5140846
to
dfc4a77
Compare
Add lazy initialized cache for public service methods for each queried class. Additionally fetching all public methods of a class at once avoids catching NoSuchMethodExceptions when trying to find a method. This change avoids repeated NoSuchMethodException when checking if access is allowed for services using interfaces and abstract class in their hierarchy, where not every super class contains an implementation of the invoked method. 359668
paolobazzi
force-pushed
the
features/pbz/24.2/359668-service-invoker-reflection
branch
from
dfc4a77
to
1e5e40f
Compare
mvilliger
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lazy initialized cache for public service methods for each queried class. Additionally fetching all public methods of a class at once avoids catching NoSuchMethodExceptions when trying to find a method.
This change avoids repeated NoSuchMethodException when checking if access is allowed for services using interfaces and abstract class in their hierarchy, where not every super class contains an implementation of the invoked method.
359668