Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH_ACTION_TOKEN secret #12

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

pcdavid
Copy link
Member

@pcdavid pcdavid commented Feb 9, 2024

Needed for the GitHub Actions workflow in sirius-website-sources to push the result into sirius-website.

See https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4254 for context.

Needed for the GitHub Actions workflow in sirius-website-sources to
push the result into sirius-website.

See https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4254 for
context.

Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid requested review from a team as code owners February 9, 2024 08:43
Copy link

github-actions bot commented Feb 9, 2024

Diff for 63f10f8:
Printing local diff:

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization modeling.sirius[id=eclipse-sirius]
  there have been 4 validation infos, enable verbose output with '-v' to to display them.

+   add repo_secret[name="GH_ACTION_TOKEN", repository="sirius-website-sources"] {
+     name                              = "GH_ACTION_TOKEN"
+     value                             = "pass:bots/modeling.sirius/github.com/api-token"
+   }
  
  Plan: 1 to add, 0 to change, 0 to delete.
Canonical Diff for 63f10f8:
Showing canonical diff:

Organization modeling.sirius[id=eclipse-sirius]

--- canonical
+++ original
@@ -63,7 +63,6 @@
       default_branch: "master"
       delete_branch_on_merge: false
       description: "Sirius Legacy: legacy (unmaintained) components from Sirius Desktop"
-      has_discussions: false
       has_issues: false
       has_projects: false
       has_wiki: false
@@ -130,7 +129,6 @@
     orgs.newRepo('sirius-website-sources') {
       allow_squash_merge: false
       allow_update_branch: false
-      default_branch: "main"
       delete_branch_on_merge: false
       description: "Sources of the Eclipse Sirius website"
       has_projects: false

@netomi
Copy link
Contributor

netomi commented Feb 9, 2024

LGTM.

@heurtematte, @pstankie : I checked, the cdt-cloud (where we copy the setup from) project has an api-token setup that only has public_repo as scope which would be needed here. The api-token for sirius was created as Jenkins GitHub plugin token, and has scopes admin:repo_hook and public_repo. So either we use the same token here or create a dedicated action-token that only has public_repo scope, WDYT?

@pcdavid
Copy link
Member Author

pcdavid commented Feb 12, 2024

LGTM.

@heurtematte, @pstankie : I checked, the cdt-cloud (where we copy the setup from) project has an api-token setup that only has public_repo as scope which would be needed here. The api-token for sirius was created as Jenkins GitHub plugin token, and has scopes admin:repo_hook and public_repo. So either we use the same token here or create a dedicated action-token that only has public_repo scope, WDYT?

Ping (not that this is urgent, but I'm this close to get done with this particular subject and I'd like to complete it while it's still fresh).

@netomi
Copy link
Contributor

netomi commented Feb 12, 2024

Lets merge the PR as is, the token can be changed later on if needed.

@netomi netomi merged commit a9bfea5 into eclipse-sirius:main Feb 12, 2024
2 checks passed
@netomi
Copy link
Contributor

netomi commented Feb 12, 2024

change is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants